X-Git-Url: https://eleni.mutantstargoat.com/git/?p=demo;a=blobdiff_plain;f=src%2Fvulkan%2Fvkutil.cc;h=65467c563a014ecb24a56ca8028fd71db3c7efaa;hp=698e6f8d17e2bfa2f964ca0e320cc3679506198f;hb=8fb0cca684e078cd2537070c53ad970ebbc2e9a7;hpb=72995482b98ff2a014ddd737131a0935ead89977

diff --git a/src/vulkan/vkutil.cc b/src/vulkan/vkutil.cc
index 698e6f8..65467c5 100644
--- a/src/vulkan/vkutil.cc
+++ b/src/vulkan/vkutil.cc
@@ -1,3 +1,4 @@
+#include <gmath/gmath.h>
 #include <vulkan/vulkan.h>
 #include <stdio.h>
 #include <stdint.h>
@@ -9,24 +10,27 @@
 #include "vkutil.h"
 
 /* global variables */
-
-VkPipeline *vkgraphics_pipeline;
+VkPhysicalDevice vk_physical;
+VkDevice vk_device;
+VkCommandPool vk_pool;
+VkQueue vk_queue;
+VkSurfaceKHR vk_surface;
+VkSwapchainKHR vk_swapchain;
+
+VkPipeline *vkgparent_pipeline;
 VkFramebuffer *vkfbufs;
 VkRenderPass vkrpass;
-VkSwapchainKHR vkswapchain;
-VkImage *vkswapchain_images;
-VkImageView *vkswapchain_views;
-int vknum_swapchain_images;
-int vknext_swapchain_image;
-VkSurfaceKHR vksurface;
 VkInstance vkinst;
-VkPhysicalDevice vkpdev;
-VkDevice vkdev;
-VkQueue vkq;
-VkCommandPool vkcmdpool;
 VkCommandBuffer vkcmdbuf;	/* primary command buffer */
 int vkqfamily;
 
+VkSemaphore vk_img_avail_sema;
+VkSemaphore vk_rend_done_sema;
+VkImage *vkswapchain_images;
+VkImageView *vkswapchain_views;
+int vknum_swapchain_images;
+int vk_curr_swapchain_image;
+
 /* static functions */
 static const char *get_device_name_str(VkPhysicalDeviceType type);
 static const char *get_memtype_flags_str(VkMemoryPropertyFlags flags);
@@ -196,7 +200,7 @@ bool vku_create_device()
 
 	if(sel_dev < 0 || sel_qfamily < 0) {
 		fprintf(stderr, "failed to find any device with a graphics-capable command queue\n");
-		vkDestroyDevice(vkdev, 0);
+		vkDestroyDevice(vk_device, 0);
 		return false;
 	}
 
@@ -222,16 +226,16 @@ bool vku_create_device()
 	dev_info.enabledExtensionCount = sizeof devext_names / sizeof *devext_names;
 	dev_info.ppEnabledExtensionNames = devext_names;
 
-	if(vkCreateDevice(phys_devices[sel_dev], &dev_info, 0, &vkdev) != 0) {
+	if(vkCreateDevice(phys_devices[sel_dev], &dev_info, 0, &vk_device) != 0) {
 		fprintf(stderr, "failed to create device %d\n", sel_dev);
 		return false;
 	}
 	printf("created device %d\n", sel_dev);
 
-	vkpdev = phys_devices[sel_dev];
+	vk_physical = phys_devices[sel_dev];
 	vkqfamily = sel_qfamily;
 
-	vkGetDeviceQueue(vkdev, sel_qfamily, 0, &vkq);
+	vkGetDeviceQueue(vk_device, sel_qfamily, 0, &vk_queue);
 
 	/* create command buffer pool */
 	memset(&cmdpool_info, 0, sizeof cmdpool_info);
@@ -239,15 +243,15 @@ bool vku_create_device()
 	cmdpool_info.flags = VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT;
 	cmdpool_info.queueFamilyIndex = sel_qfamily;
 
-	if(vkCreateCommandPool(vkdev, &cmdpool_info, 0, &vkcmdpool) != 0) {
-		fprintf(stderr, "failed to get command quque!\n");
+	if(vkCreateCommandPool(vk_device, &cmdpool_info, 0, &vk_pool) != 0) {
+		fprintf(stderr, "failed to get command queue!\n");
 		return false;
 	}
 
-	if(!(vkcmdbuf = vku_alloc_cmdbuf(vkcmdpool, VK_COMMAND_BUFFER_LEVEL_PRIMARY))) {
+/*	if(!(vkcmdbuf = vku_alloc_cmdbuf(vk_pool, VK_COMMAND_BUFFER_LEVEL_PRIMARY))) {
 		fprintf(stderr, "failed to create primary command buffer\n");
 		return false;
-	}
+	} */
 
 	return true;
 }
@@ -255,9 +259,13 @@ bool vku_create_device()
 void vku_cleanup()
 {
 	if(vkinst) {
-		vkDeviceWaitIdle(vkdev);
-		vkDestroyCommandPool(vkdev, vkcmdpool, 0);
-		vkDestroyDevice(vkdev, 0);
+		vkDeviceWaitIdle(vk_device);
+		vkDestroyCommandPool(vk_device, vk_pool, 0);
+
+		vkDestroySemaphore(vk_device, vk_img_avail_sema, 0);
+		vkDestroySemaphore(vk_device, vk_rend_done_sema, 0);
+
+		vkDestroyDevice(vk_device, 0);
 		vkDestroyInstance(vkinst, 0);
 		vkinst = 0;
 	}
@@ -266,6 +274,25 @@ void vku_cleanup()
 	phys_devices = 0;
 }
 
+bool vku_create_semaphores()
+{
+	VkSemaphoreCreateInfo sinf;
+	memset(&sinf, 0, sizeof sinf);
+
+	sinf.sType = VK_STRUCTURE_TYPE_SEMAPHORE_CREATE_INFO;
+	if(vkCreateSemaphore(vk_device, &sinf, 0, &vk_img_avail_sema) != VK_SUCCESS) {
+		fprintf(stderr, "Failed to create semaphore\n");
+		return false;
+	}
+
+	if(vkCreateSemaphore(vk_device, &sinf, 0, &vk_rend_done_sema) != VK_SUCCESS) {
+		fprintf(stderr, "Failed to create semaphore\n");
+		return false;
+	}
+
+	return true;
+}
+
 VkCommandBuffer vku_alloc_cmdbuf(VkCommandPool pool, VkCommandBufferLevel level)
 {
 	VkCommandBuffer cmdbuf;
@@ -277,7 +304,7 @@ VkCommandBuffer vku_alloc_cmdbuf(VkCommandPool pool, VkCommandBufferLevel level)
 	inf.level = level;
 	inf.commandBufferCount = 1;
 
-	if(vkAllocateCommandBuffers(vkdev, &inf, &cmdbuf) != 0) {
+	if(vkAllocateCommandBuffers(vk_device, &inf, &cmdbuf) != 0) {
 		return 0;
 	}
 	return cmdbuf;
@@ -285,7 +312,7 @@ VkCommandBuffer vku_alloc_cmdbuf(VkCommandPool pool, VkCommandBufferLevel level)
 
 void vku_free_cmdbuf(VkCommandPool pool, VkCommandBuffer buf)
 {
-	vkFreeCommandBuffers(vkdev, pool, 1, &buf);
+	vkFreeCommandBuffers(vk_device, pool, 1, &buf);
 }
 
 void vku_begin_cmdbuf(VkCommandBuffer buf, unsigned int flags)
@@ -325,26 +352,49 @@ void vku_submit_cmdbuf(VkQueue q, VkCommandBuffer buf, VkFence done_fence)
 VkSwapchainKHR vku_create_swapchain(VkSurfaceKHR surf, int xsz, int ysz, int n,
                                     VkPresentModeKHR pmode, VkSwapchainKHR prev)
 {
+	VkSurfaceCapabilitiesKHR scap;
+	vkGetPhysicalDeviceSurfaceCapabilitiesKHR(vk_physical, surf, &scap);
+
+	VkPhysicalDeviceMemoryProperties mprops;
+	vkGetPhysicalDeviceMemoryProperties(vk_physical, &mprops);
+
+	uint32_t pmcnt;
+	vkGetPhysicalDeviceSurfacePresentModesKHR(vk_physical, surf, &pmcnt, 0);
+	VkPresentModeKHR scpm = VK_PRESENT_MODE_IMMEDIATE_KHR;
+	VkExtent2D scext;
+	scext.width = xsz;
+	scext.height = ysz;
+
+//	VkSurfaceTransformFlagBitsKHR pretransf;
+//	if(scap.supportedTransforms & VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR) {
+//		pretransf = VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR;
+//	} else {
+//		pretransf = scap.currentTransform;
+//	}
+
 	VkSwapchainKHR sc;
 	VkSwapchainCreateInfoKHR inf;
 
+	VkSurfaceFormatKHR sformat;
+	sformat.format = VK_FORMAT_B8G8R8A8_UNORM;
+
 	memset(&inf, 0, sizeof inf);
 	inf.sType = VK_STRUCTURE_TYPE_SWAPCHAIN_CREATE_INFO_KHR;
 	inf.surface = surf;
 	inf.minImageCount = n;
-	inf.imageFormat = VK_FORMAT_B8G8R8A8_UNORM;	/* TODO enumerate and choose */
-	inf.imageColorSpace = VK_COLORSPACE_SRGB_NONLINEAR_KHR;
-	inf.imageExtent.width = xsz;
-	inf.imageExtent.height = ysz;
+	inf.imageFormat = sformat.format;	/* TODO enumerate and choose */
+	inf.imageColorSpace = sformat.colorSpace;
+	inf.imageExtent = scext;
 	inf.imageArrayLayers = 1;
 	inf.imageUsage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;
 	inf.imageSharingMode = VK_SHARING_MODE_EXCLUSIVE;	/* XXX make this an option? */
 	inf.preTransform = VK_SURFACE_TRANSFORM_INHERIT_BIT_KHR;
 	inf.compositeAlpha = VK_COMPOSITE_ALPHA_OPAQUE_BIT_KHR;
 	inf.presentMode = pmode;
-	inf.oldSwapchain = prev;
+	inf.oldSwapchain = VK_NULL_HANDLE;
+	inf.clipped = VK_TRUE;
 
-	if(vkCreateSwapchainKHR(vkdev, &inf, 0, &sc) != 0) {
+	if(vkCreateSwapchainKHR(vk_device, &inf, 0, &sc) != 0) {
 		return 0;
 	}
 	return sc;
@@ -355,11 +405,11 @@ VkImage *vku_get_swapchain_images(VkSwapchainKHR sc, int *count)
 	uint32_t nimg;
 	VkImage *images;
 
-	if(vkGetSwapchainImagesKHR(vkdev, sc, &nimg, 0) != 0) {
+	if(vkGetSwapchainImagesKHR(vk_device, sc, &nimg, 0) != 0) {
 		return 0;
 	}
 	images = new VkImage[nimg];
-	vkGetSwapchainImagesKHR(vkdev, sc, &nimg, images);
+	vkGetSwapchainImagesKHR(vk_device, sc, &nimg, images);
 
 	if(count) *count = (int)nimg;
 	return images;
@@ -384,7 +434,7 @@ VkImageView *vku_create_image_views(VkImage *images, int count)
 		inf.subresourceRange.levelCount = 1;
 		inf.subresourceRange.layerCount = 1;
 
-		if(vkCreateImageView(vkdev, &inf, 0, iviews) != 0) {
+		if(vkCreateImageView(vk_device, &inf, 0, iviews) != 0) {
 			fprintf(stderr, "Failed to create image views.\n");
 			delete iviews;
 			return 0;
@@ -398,7 +448,7 @@ int vku_get_next_image(VkSwapchainKHR sc)
 {
 	uint32_t next;
 
-	if(vkAcquireNextImageKHR(vkdev, sc, UINT64_MAX, 0, 0, &next) != 0) {
+	if(vkAcquireNextImageKHR(vk_device, sc, UINT64_MAX, 0, 0, &next) != 0) {
 		return -1;
 	}
 	return (int)next;
@@ -417,7 +467,7 @@ void vku_present(VkSwapchainKHR sc, int img_idx)
 	inf.pImageIndices = &index;
 	inf.pResults = &res;
 
-	vkQueuePresentKHR(vkq, &inf);
+	vkQueuePresentKHR(vk_queue, &inf);
 }
 
 bool vku_create_renderpass()
@@ -470,7 +520,7 @@ bool vku_create_renderpass()
 	inf.subpassCount = 1;
 	inf.pSubpasses = &subpass_desc;
 
-	if(vkCreateRenderPass(vkdev, &inf, 0, &vkrpass) != VK_SUCCESS) {
+	if(vkCreateRenderPass(vk_device, &inf, 0, &vkrpass) != VK_SUCCESS) {
 		return false;
 	}
 
@@ -494,7 +544,7 @@ bool vku_create_framebuffers(VkImageView *image_views, int count, int w, int h)
 	inf.layers = 1;
 
 	for(int i=0; i<count; i++) {
-		if(vkCreateFramebuffer(vkdev, &inf, 0, &vkfbufs[i]) != VK_SUCCESS) {
+		if(vkCreateFramebuffer(vk_device, &inf, 0, &vkfbufs[i]) != VK_SUCCESS) {
 			fprintf(stderr, "Failed to create framebuffer for image view: %d\n", i);
 			delete vkfbufs;
 			return false;
@@ -516,7 +566,7 @@ struct vku_buffer *vku_create_buffer(int sz, unsigned int usage)
 	binfo.usage = usage;
 	binfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE;
 
-	if(vkCreateBuffer(vkdev, &binfo, 0, &buf->buf) != 0) {
+	if(vkCreateBuffer(vk_device, &binfo, 0, &buf->buf) != 0) {
 		fprintf(stderr, "failed to create %d byte buffer (usage: %x)\n", sz, usage);
 		return 0;
 	}
@@ -527,7 +577,7 @@ struct vku_buffer *vku_create_buffer(int sz, unsigned int usage)
 void vku_destroy_buffer(struct vku_buffer *buf)
 {
 	if(buf) {
-		vkDestroyBuffer(vkdev, buf->buf, 0);
+		vkDestroyBuffer(vk_device, buf->buf, 0);
 		delete buf;
 	}
 }
@@ -543,257 +593,6 @@ void vku_cmd_copybuf(VkCommandBuffer cmdbuf, VkBuffer dest, int doffs,
 	vkCmdCopyBuffer(cmdbuf, src, dest, 1, &copy);
 }
 
-/* paste
-
-static bool create_instance()
-{
-	uint32_t layer_count = 0;
-	std::vector<const char *> enabled_layers;
-
-	if(vkEnumerateInstanceLayerProperties(&layer_count, 0) != VK_SUCCESS) {
-		fprintf(stderr, "Failed to query layer properties.\n");
-		return false;
-	}
-
-	if(layer_count > 0) {
-		VkLayerProperties *layers = (VkLayerProperties *)alloca(layer_count * sizeof *layers);
-		vkEnumerateInstanceLayerProperties(&layer_count, layers);
-		for(uint32_t i=0; i<layer_count; i++) {
-			if(strcmp(layers[i].layerName, "VK_LAYER_LUNARG_standard_validation")) {
-				enabled_layers.push_back(layers[i].layerName);
-			}
-		}
-	}
-
-	uint32_t extensions_count = 0;
-	std::vector<const char *> enabled_extensions;
-
-	if(vkEnumerateInstanceExtensionProperties(0, &extensions_count, 0) != VK_SUCCESS) {
-		fprintf(stderr, "Failed to enumerate instance extension properties\n");
-		return false;
-	}
-
-	if(extensions_count > 0) {
-		VkExtensionProperties *extensions = (VkExtensionProperties *)alloca(extensions_count * sizeof *extensions);
-		vkEnumerateInstanceExtensionProperties(0, &extensions_count, extensions);
-
-		for(uint32_t i=0; i<extensions_count; i++) {
-			printf("Extension %u: %s %u.\n", i, extensions[i].extensionName, extensions[i].specVersion);
-			//enable all the available extensions
-			enabled_extensions.push_back(extensions[i].extensionName);
-			enabled_extension_names.push_back(std::string(extensions[i].extensionName));
-		}
-	}
-
-	VkInstanceCreateInfo create_info;
-	memset(&create_info, 0, sizeof create_info);
-	create_info.sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO;
-
-	if(!enabled_layers.empty()) {
-		create_info.enabledLayerCount = enabled_layers.size();
-		create_info.ppEnabledLayerNames = enabled_layers.data();
-	}
-
-	if(!enabled_extensions.empty()) {
-		create_info.enabledExtensionCount = enabled_extensions.size();
-		create_info.ppEnabledExtensionNames = enabled_extensions.data();
-	}
-
-	if(vkCreateInstance(&create_info, 0, &inst) != VK_SUCCESS) {
-		fprintf(stderr, "Failed to create instance.\n");
-		return false;
-	}
-
-	if(!create_device())
-		return false;
-
-	return true;
-}
-
-static bool create_device()
-{
-	int qfam_idx = -1;
-	int pdev_idx = -1;
-
-	uint32_t dev_count;
-	if(vkEnumeratePhysicalDevices(inst, &dev_count, 0) != VK_SUCCESS) {
-		fprintf(stderr, "Failed to enumerate physical devices.\n");
-		return false;
-	}
-	printf("%u devices found.\n", (unsigned int)dev_count);
-
-	VkPhysicalDevice *phys_dev = (VkPhysicalDevice *)alloca(dev_count * sizeof *phys_dev);
-	vkEnumeratePhysicalDevices(inst, &dev_count, phys_dev);
-	VkPhysicalDeviceMemoryProperties memprop;
-
-	for(uint32_t i=0; i<dev_count; i++) {
-		VkPhysicalDeviceProperties dev_props;
-		vkGetPhysicalDeviceProperties(phys_dev[i], &dev_props);
-
-		//memory heaps:
-		vkGetPhysicalDeviceMemoryProperties(phys_dev[i], &memprop);
-		printf("\tNumber of heaps: %u\n", memprop.memoryHeapCount);
-		for(uint32_t j=0; j<memprop.memoryHeapCount; j++) {
-			printf("\t\tHeap %u size: %lu\n", j, (unsigned long)memprop.memoryHeaps[j].size);
-			printf("\t\tHeap %u flags: %s\n", j, heap_flags_str(memprop.memoryHeaps[j].flags));
-		}
-		//memory types
-		printf("\tMemory types: %u\n", memprop.memoryTypeCount);
-		for(uint32_t j=0; j<memprop.memoryTypeCount; j++) {
-			printf("\t\tType %u heap index: %u\n", j, memprop.memoryTypes[j].heapIndex);
-			printf("\t\tType %u flags: %s\n", j, memtype_flags_str(memprop.memoryTypes[j].propertyFlags));
-		}
-
-		//supported features
-		VkPhysicalDeviceFeatures features;
-		vkGetPhysicalDeviceFeatures(phys_dev[i], &features);
-
-		//queue families
-		uint32_t qfam_count;
-		vkGetPhysicalDeviceQueueFamilyProperties(phys_dev[i], &qfam_count, 0);
-		printf("\tQueue Families: %u\n", qfam_count);
-		VkQueueFamilyProperties *qfam_props = new VkQueueFamilyProperties[qfam_count];
-		vkGetPhysicalDeviceQueueFamilyProperties(phys_dev[i], &qfam_count, qfam_props);
-		for(uint32_t j=0; j<qfam_count; j++) {
-			printf("\t\tFamily %u flags: %s\n", j, queue_flags_str(qfam_props[j].queueFlags));
-			printf("\t\tFamily %u number of queues: %u\n", j, qfam_props[j].queueCount);
-
-			if((qfam_props[j].queueFlags & VK_QUEUE_GRAPHICS_BIT) && (pdev_idx == -1)) {
-				pdev_idx = i;
-				qfam_idx = j;
-				num_queues = qfam_props[j].queueCount;
-			}
-		}
-		delete [] qfam_props;
-	}
-
-	if(pdev_idx == -1) {
-		fprintf(stderr, "No suitable devices found.\n");
-		return false;
-	}
-
-	pdev = *(phys_dev + pdev_idx);
-	qfamily_idx = qfam_idx;
-
-		uint32_t layer_count;
-		if(vkEnumerateDeviceLayerProperties(pdev, &layer_count, 0) != VK_SUCCESS) {
-			fprintf(stderr, "Failed to enumerate device layers.\n");
-			return false;
-		}
-		if(layer_count > 0) {
-			VkLayerProperties *layers = (VkLayerProperties*)alloca(layer_count * sizeof *layers);
-			vkEnumerateDeviceLayerProperties(pdev, &layer_count, layers);
-			printf("%u layers found.\n", layer_count);
-			for(uint32_t i=0; i<layer_count; i++) {
-				printf("Layer %u: %s (%u, %u)\n", i, layers[i].layerName,
-						layers[i].specVersion, layers[i].implementationVersion);
-				printf("\tDesc: %s\n", layers[i].description);
-			}
-		}
-
-	VkDeviceCreateInfo dev_info;
-	memset(&dev_info, 0, sizeof dev_info);
-	dev_info.sType = VK_STRUCTURE_TYPE_DEVICE_CREATE_INFO;
-
-	VkDeviceQueueCreateInfo dev_qinfo;
-	memset(&dev_qinfo, 0, sizeof dev_qinfo);
-	dev_qinfo.sType = VK_STRUCTURE_TYPE_DEVICE_QUEUE_CREATE_INFO;
-	dev_qinfo.queueFamilyIndex = qfam_idx;
-	dev_qinfo.queueCount = 1;
-
-	dev_info.queueCreateInfoCount = 1;
-	dev_info.pQueueCreateInfos = &dev_qinfo;
-
-	if(vkCreateDevice(pdev, &dev_info, 0, &device) != VK_SUCCESS) {
-		fprintf(stderr, "Failed to create logical device.\n");
-		return false;
-	}
-
-	vkGetPhysicalDeviceMemoryProperties(pdev, &memprop);
-	for(uint32_t j=0; j<memprop.memoryTypeCount; j++) {
-		if(memprop.memoryTypes[j].propertyFlags & VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT) {
-			device_mem_idx = j;
-			printf("Selected device memory index: %u\n", device_mem_idx);
-			break;
-		}
-	}
-
-	return true;
-}
-
-static const char *dev_type_str(VkPhysicalDeviceType type)
-{
-	switch(type) {
-	case VK_PHYSICAL_DEVICE_TYPE_OTHER:
-		return "other";
-	case VK_PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU:
-		return "integrated GPU";
-	case VK_PHYSICAL_DEVICE_TYPE_DISCRETE_GPU:
-		return "discrete GPU";
-	case VK_PHYSICAL_DEVICE_TYPE_VIRTUAL_GPU:
-		return "virtual GPU";
-	case VK_PHYSICAL_DEVICE_TYPE_CPU:
-		return "CPU";
-	default:
-		break;
-	}
-	return "unknown";
-}
-
-static const char *heap_flags_str(VkMemoryHeapFlags flags)
-{
-	static std::string str;
-	str.clear();
-	if(flags & VK_MEMORY_HEAP_DEVICE_LOCAL_BIT) {
-		str += "device-local ";
-	}
-	if(!str.empty())
-		str.pop_back();
-	return str.c_str();
-}
-
-static const char *memtype_flags_str(VkMemoryPropertyFlags flags)
-{
-	static std::string str;
-	str.clear();
-	if(flags & VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT) {
-		str += "device-local ";
-	}
-	if(flags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) {
-		str += "host-visible ";
-	}
-	if(flags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) {
-		str += "host-coherent ";
-	}
-	if(flags & VK_MEMORY_PROPERTY_HOST_CACHED_BIT) {
-		str += "host-cached ";
-	}
-	if(flags & VK_MEMORY_PROPERTY_LAZILY_ALLOCATED_BIT) {
-		str += "lazily-allocated ";
-	}
-	if(!str.empty())
-		str.pop_back();
-	return str.c_str();
-}
-
-static const char *queue_flags_str(VkQueueFlags flags)
-{
-	static std::string str;
-	str.clear();
-	if(flags & VK_QUEUE_GRAPHICS_BIT)
-		str += "graphics ";
-	if(flags & VK_QUEUE_COMPUTE_BIT)
-		str += "compute ";
-	if(flags & VK_QUEUE_TRANSFER_BIT)
-		str += "transfer ";
-	if(flags & VK_QUEUE_SPARSE_BINDING_BIT)
-		str += "sparse-binding ";
-	if(!str.empty())
-		str.pop_back();
-	return str.c_str();
-}
-*/
-
 const char *vku_get_vulkan_error_str(VkResult error)
 {
 	std::string errmsg;
@@ -839,7 +638,6 @@ const char *vku_get_vulkan_error_str(VkResult error)
 		break;
 	case VK_ERROR_FEATURE_NOT_PRESENT:
 		errmsg = std::string("VK_ERROR_FEATURE_NOT_PRESENT");
-		break;
 	case VK_ERROR_INCOMPATIBLE_DRIVER:
 		errmsg = std::string("VK_ERROR_INCOMPATIBLE_DRIVER");
 		break;
@@ -904,13 +702,13 @@ bool vku_create_graphics_pipeline(VkPipelineLayout *layout)
 	vs.scissorCount = 1;
 
 	/* dynamic states: that can be changed later */
-	std::vector<VkDynamicState> ds_enabled;
-	ds_enabled.push_back(VK_DYNAMIC_STATE_VIEWPORT);
+//	std::vector<VkDynamicState> ds_enabled;
+//	ds_enabled.push_back(VK_DYNAMIC_STATE_VIEWPORT);
 	//ds_enabled.push_back(VK_DYNAMIC_STATE_SCISSOR);
-	VkPipelineDynamicStateCreateInfo ds;
-	ds.sType = VK_STRUCTURE_TYPE_PIPELINE_DYNAMIC_STATE_CREATE_INFO;
-	ds.pDynamicStates = ds_enabled.data();
-	ds.dynamicStateCount = static_cast<uint32_t>(ds_enabled.size());
+//	VkPipelineDynamicStateCreateInfo ds;
+//	ds.sType = VK_STRUCTURE_TYPE_PIPELINE_DYNAMIC_STATE_CREATE_INFO;
+//	ds.pDynamicStates = ds_enabled.data();
+//	ds.dynamicStateCount = static_cast<uint32_t>(ds_enabled.size());
 
 	/* depth tests */
 	VkPipelineDepthStencilStateCreateInfo dsi;
@@ -930,7 +728,17 @@ bool vku_create_graphics_pipeline(VkPipelineLayout *layout)
 	msi.sType = VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO;
 	msi.rasterizationSamples = VK_SAMPLE_COUNT_1_BIT;
 
-	//TODO in progress
+	/* vertex input descriptions */
+	VkVertexInputBindingDescription vib;
+	memset(&vib, 0, sizeof vib);
+	vib.stride = sizeof(Vec3);
+	vib.inputRate = VK_VERTEX_INPUT_RATE_VERTEX;
+
+	/* input attr bindings */
+	VkVertexInputAttributeDescription via[2];
+	memset(&via, 0, sizeof via);
+	via[0].format = VK_FORMAT_R32G32B32A32_SFLOAT;
+
 	return true;
 }